Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #419

Merged
merged 9 commits into from
Nov 13, 2023
Merged

Update dependencies #419

merged 9 commits into from
Nov 13, 2023

Conversation

kyscott18
Copy link
Collaborator

No description provided.

@railway-app Railway App
Copy link

railway-app bot commented Nov 10, 2023

This PR was not deployed automatically as @kyscott18 does not have access to the Railway project.

In order to get automatic PR deploys, please add @kyscott18 to the project inside the project settings page.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 159e0a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ponder-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2023 8:45pm

0xOlias
0xOlias reviewed Nov 11, 2023
View reviewed changes
Copy link
Collaborator

@0xOlias 0xOlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like create-ponder deps and tsconfig need to be updated as well. Looking good though!

I suspect we might run into issues with some dep breaking changes, notably p-queue.

packages/core/src/server/graphql/entity.ts
@@ -70,8 +70,8 @@ export const buildEntityTypes = ({
fieldConfigMap[columnName] = {
type: new GraphQLNonNull(
new GraphQLList(
new GraphQLNonNull(entityGqlTypes[column.referenceTable])
)
new GraphQLNonNull(entityGqlTypes[column.referenceTable]),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a bit strange to me that this line would have a comma. Is this what folks are doing with their lint rules these days?

@kyscott18 kyscott18 merged commit ad1c565 into main Nov 13, 2023
2 of 9 checks passed
@kyscott18 kyscott18 deleted the kjs/deps branch November 13, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xOlias 0xOlias 0xOlias left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyscott18 @0xOlias